Repository navigation
fix(memory): isolate project access and automate memory cleanup - #166
Merged
Merged
Conversation
Bind thread knowledge tools to their project and environment. Add bounded, reversible background memory curation with source and revision validation, project settings, review history, and user-only restoration across clients.
|
Fix the migration ledger, hidden-memory listing, and restore refresh fixtures. Correct Cursor and OpenCode curation test types and record the measured MCP context size. The agent-context-increase maintainer gate remains required.
Apply curator retirement as automatic forgetting, erase stored history and delivery copies, discard non-standing learning proposals, and clean prior automatic retirements in bounded background batches. Remove set-aside browsing from web and mobile while retaining owner protections and manual supersession controls.
AssistedLearning now discards task and code verdicts before saving, so saveAutomatic no longer takes a verdict or returns "discarded". This also removes the unreachable "unsupported assertion" note, and the test fixtures no longer set a standing-check capability that no client reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Thread-bound MCP knowledge tools accepted a caller-supplied project ID without comparing it with the authenticated thread. This let a thread read or change another project's memory. Automatically collected memories also needed ongoing cleanup of temporary notes, duplicates, and explicitly replaced decisions.
The requested behavior is fully automatic: obsolete memories are removed without a review queue, confirmation dialog, or human approval step.
Changes
Deeper inspection and validation
Failing regressions reproduced a curator classification surviving a human correction, retirement leaving saved content behind, non-standing proposals being stored, and old retired rows never being cleaned. All pass after the changes.
Check status and limits
The required
vp run check:changed HEAD --concurrency 1 --skip-testscommand was run. Its cached typecheck step is blocked by the workspace's nested seccomp supervisor; the direct focused checks above passed. Behavioral suites were run separately. Local Chromium cannot create its required socket, so the updated browser interaction regression is left to hosted CI. Full hosted CI passed on the preceding head and is being rerun for this change.An extra localization audit reports the existing
Inference accountscatalog key missing onmain; this follow-up did not introduce that key.The advertised MCP tool list measures 74,746 bytes, 398 bytes above main's 74,348. The context-budget workflow passed for this head with the required
agent-context-increaselabel already present. This repository merge check is unchanged; the runtime curator has no human approval step.This changes the code and PR branch; it does not rewrite a live user's database. Forgetting removes T3's stored memory copies and future recall, not information a provider already consumed in its existing native context.
Model and harness: GPT-6 Astra Pro in the ChatGPT shared workspace, with delegated implementation and review agents; GPT-6 Luna for the real-model evaluations.